Dataloader Draft #24
Merged
Dataloader Draft #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateibejan1
approved these changes
Oct 18, 2022
lucapinello
reviewed
Oct 18, 2022
src/data/sequence_dataloader.py
Outdated
| from torch.utils.data import Dataset, DataLoader | ||
|
|
||
| class SequenceDatasetBase(Dataset): | ||
| def __init__(self, data_path, transform=None): |
There was a problem hiding this comment.
maybe add here sequence_lenght=200 so we have flexibility later
lucapinello
reviewed
Oct 18, 2022
src/data/sequence_dataloader.py
Outdated
| # Iterating through DNA sequences from dataset and one-hot encoding all nucleotides | ||
| current_seq = self.data["raw_sequence"][index] | ||
| if 'N' not in current_seq: | ||
| X_seq = np.array(self.one_hot_encode(current_seq, ['A','C','T','G'], 200)) |
There was a problem hiding this comment.
here we can replace 200 with self.sequence_length
lucapinello
reviewed
Oct 18, 2022
src/data/sequence_dataloader.py
Outdated
| return X_seq, X_cell_type | ||
|
|
||
| # Function for one hot encoding each line of the sequence dataset | ||
| def one_hot_encode(self, seq, alphabet, max_seq_len): |
There was a problem hiding this comment.
replace max_seq_len with sequence_length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataloader is now up to date with all changes regarding one-hot encoding of components and renamed to suit our new folder structure.
See #17 for earlier discussion.