Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC warnings #84

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix GCC warnings #84

wants to merge 10 commits into from

Conversation

lupyuen
Copy link

@lupyuen lupyuen commented Dec 27, 2020

This PR fixes the warnings in BL602 HAL generated by xpack-riscv-none-embed-gcc 8.3.0-2.3 when building for Mynewt OS. The warnings were due to buffer overflow, mismatched types, missing declarations and variables set but not used.

@tchebb
Copy link

tchebb commented Jan 1, 2021

These changes look good, thanks! Do you mind squashing the commits together? I'm generally in favor of as granular commits as possible, but one commit per line change seems a little excessive :) (I can also just merge with squash if you prefer that, but you won't have control over the final commit message if I do it that way.)

@lupyuen
Copy link
Author

lupyuen commented Jan 1, 2021

Yes could you please merge with squash for me thanks! I haven't done squashing before and I'll probably mess it up 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants