Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integer-based interface supporting SCM work #53

Draft
wants to merge 248 commits into
base: develop
Choose a base branch
from

Conversation

hbierlee
Copy link
Collaborator

@hbierlee hbierlee commented May 15, 2024

Introduce an integer-based interface for adding linear constraints, which is also used to implement some of the encoding algorithms. Major features:

  • Improve order and binary encoding of variables
  • Stabilize uniform order (bdd/gt) constraints and binary constraint (rca from gt/bdd decomp)
    • Note: mixed encoding almost there, but not quite stable
  • Basic modeling interface
  • Single constant multiplication databases for binary encoding of terms

TODO's before merge:

  • Clippy / PRINT_COUPLING problem?
  • Add expect_test!
  • Refactor: TestDB::solve(..) duplicates some stuff from check_complete
  • Yet more tests currently commented out that still need fixing
  • Documentation (currently sparse and basic, not checked for completeness)
    • Related: probably some pub -> pub(crate)
  • Migrate ecm/*.dimacs into Cnf source rust code objects

Feature requests to be handled later

  • Move cnf: Vec<Vec<Lit>> functions into Cnf
  • Reorganize testing in model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants