Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/enum support #681

Merged
merged 9 commits into from
Aug 17, 2022
Merged

Conversation

dkaera
Copy link
Collaborator

@dkaera dkaera commented Jul 19, 2022

No description provided.

example/lib/main.dart Outdated Show resolved Hide resolved
example/lib/main.dart Show resolved Hide resolved
example/lib/main.dart Outdated Show resolved Hide resolved
example/lib/task.dart Outdated Show resolved Hide resolved
floor_generator/lib/misc/type_utils.dart Show resolved Hide resolved
floor_generator/lib/misc/type_utils.dart Outdated Show resolved Hide resolved
@dkaera dkaera force-pushed the feature/enum_support branch 2 times, most recently from c373f59 to abb143b Compare July 26, 2022 12:41
mqus
mqus previously approved these changes Jul 26, 2022
@dkaera dkaera requested review from vitusortner and ThomasMiddel and removed request for vitusortner and ThomasMiddel July 27, 2022 06:52
@dkaera
Copy link
Collaborator Author

dkaera commented Jul 27, 2022

Hey @mqus @vitusortner @ThomasMiddel do you know why codecov/patch and codecov/project does not start?

@dkaera dkaera requested review from memoriasIT and mqus July 27, 2022 10:50
Copy link

@memoriasIT memoriasIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is my first review and contact with the project so take it with a grain of salt :)

@dkaera dkaera enabled auto-merge (squash) July 28, 2022 16:34
@mqus
Copy link
Collaborator

mqus commented Aug 4, 2022

Hey @mqus @vitusortner @ThomasMiddel do you know why codecov/patch and codecov/project does not start?

Not sure. But the pipeline references a secret token and the output of the codecov step suggests adding a repo token
{'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

Maybe codecov also changed the way you have to configure things. No clue.

(Just to be sure though, This has to be set up anew for all clones, not sure about migrated repos. I don't know how far you investigated this already.)

@dkaera
Copy link
Collaborator Author

dkaera commented Aug 5, 2022

Hey @mqus @vitusortner @ThomasMiddel do you know why codecov/patch and codecov/project does not start?

Not sure. But the pipeline references a secret token and the output of the codecov step suggests adding a repo token {'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}

Maybe codecov also changed the way you have to configure things. No clue.

(Just to be sure though, This has to be set up anew for all clones, not sure about migrated repos. I don't know how far you investigated this already.)

got it, thanks. I guess we need project owner help.

@ThomasMiddel
Copy link
Contributor

Hey @mqus @vitusortner @ThomasMiddel do you know why codecov/patch and codecov/project does not start?

Not sure. But the pipeline references a secret token and the output of the codecov step suggests adding a repo token {'detail': ErrorDetail(string='Could not find a repository, try using repo upload token', code='not_found')}
Maybe codecov also changed the way you have to configure things. No clue.
(Just to be sure though, This has to be set up anew for all clones, not sure about migrated repos. I don't know how far you investigated this already.)

got it, thanks. I guess we need project owner help.

Codecov is still linked to @vitusortner , I'll have a look if we can migrate that or create a new account!

@ThomasMiddel ThomasMiddel disabled auto-merge August 17, 2022 07:45
@ThomasMiddel ThomasMiddel merged commit 3dbe42f into pinchbv:develop Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants