Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integration test for transaction rollback #346

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

mqus
Copy link
Collaborator

@mqus mqus commented May 27, 2020

Just to make sure that #225 does not happen normally. Technically this only tests a sqflite feature but it also checks that our interfaces/pipes are working correctly.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #346 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #346   +/-   ##
========================================
  Coverage    81.43%   81.43%           
========================================
  Files           59       59           
  Lines         1503     1503           
========================================
  Hits          1224     1224           
  Misses         279      279           
Flag Coverage Δ
#floor 81.43% <ø> (ø)
#floor_generator 81.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0284749...55d886a. Read the comment docs.

@mqus mqus requested a review from vitusortner May 27, 2020 22:02
Copy link
Collaborator

@vitusortner vitusortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mqus mqus merged commit ae1679e into develop Jun 4, 2020
@mqus mqus deleted the transaction-rollback-test branch June 4, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants