Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for ByteArrays/Blobs #259

Merged
merged 4 commits into from
Feb 23, 2020

Conversation

mqus
Copy link
Collaborator

@mqus mqus commented Feb 13, 2020

This connects the dart type Uint8List to the SQLite data type BLOB and adjusts some tests for that.
Fixes #229.

I'm a newbie to Dart/Flutter so please make sure that I did nothing wrong. I tested it locally but the test didn't get through for an unrelated reason (I assume some race condition?) But I can be wrong.

$ flutter test
00:02 +68 -1: [...]/floor/floor/test/integration/database_test.dart: database tests stream queries insert change find person by id as stream [E]                                                       
  Bad state: Cannot add new events after calling close
  dart:async                                          _BroadcastStreamController.add
  package:floor/src/adapter/query_adapter.dart 68:38  QueryAdapter.queryStream.executeQueryAndNotifyController
  ===== asynchronous gap ===========================
  dart:async                                          _asyncThenWrapperHelper
  package:floor/src/adapter/query_adapter.dart        QueryAdapter.queryStream.executeQueryAndNotifyController
  package:floor/src/adapter/query_adapter.dart 76:55  QueryAdapter.queryStream.<fn>
  ===== asynchronous gap ===========================
  dart:async                                          _ForwardingStream.listen
  package:floor/src/adapter/query_adapter.dart 75:10  QueryAdapter.queryStream
  integration/database.g.dart 167:26                  _$PersonDao.findPersonByIdAsStream
  integration/database_test.dart 274:36               main.<fn>.<fn>.<fn>.<fn>
  
00:03 +77 -1: Some tests failed.  

floor/pubspec.yaml Outdated Show resolved Hide resolved
floor_generator/lib/processor/entity_processor.dart Outdated Show resolved Hide resolved
floor_generator/lib/processor/entity_processor.dart Outdated Show resolved Hide resolved
floor_generator/lib/processor/field_processor.dart Outdated Show resolved Hide resolved
floor_generator/test/processor/field_processor_test.dart Outdated Show resolved Hide resolved
@vitusortner
Copy link
Collaborator

Thanks for your contribution to the library! I've added some remarks to the changes you added.

floor/test/integration/dao/dog_dao.dart Outdated Show resolved Hide resolved
floor_generator/lib/processor/entity_processor.dart Outdated Show resolved Hide resolved
mqus added 4 commits February 22, 2020 08:42
This connects the dart type Uint8List to the SQLite data type BLOB and adjusts some tests for that.
Fixes pinchbv#229.
@vitusortner vitusortner added the feature Request and implementation of a feature (release drafter) label Feb 23, 2020
@vitusortner vitusortner merged commit 8996e96 into pinchbv:develop Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request and implementation of a feature (release drafter)
Development

Successfully merging this pull request may close these issues.

How can I stored a Image or Blob Object?
2 participants