Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transient annotation is implemented #219

Closed

Conversation

Ghomi-Dev
Copy link

transient annotation is implemented to support the transient fields in entities

these fields should not be persisted to data tables in project's database and they only serve the data integrity

transient annotation is implemented to support the transient fields in entities

these fields should not be persisted to data tables in project's database and they only serve the data integrity
@Ghomi-Dev
Copy link
Author

Hi ,
I was in need for transient annotated field in my entity definition, I didn't find it so I implemented it in the library

please review and let me know if there is any refactor is needed

Regards

description:

transient annotation is implemented to support the transient fields in entities

these fields should not be persisted to data tables in project's database and they only serve the data integrity

@vitusortner

@Ghomi-Dev Ghomi-Dev force-pushed the transient-annotation-implementation branch 2 times, most recently from 154624a to fddfd76 Compare November 8, 2019 04:00
@vitusortner
Copy link
Collaborator

Hi @Ghomi-Dev and thanks for your contribution! I'll review it as soon as possible.

@Ghomi-Dev
Copy link
Author

Hi @Ghomi-Dev and thanks for your contribution! I'll review it as soon as possible.

Hi @vitusortner
Thanks for your kind reply, I will look forward to any pro tips you can give me to refactor or make the code better

@SeyedAbbasGhomi
Copy link

Hi @vitusortner
I appreciate it if you review my pull request

@@ -231,7 +237,7 @@ class EntityProcessor extends Processor<Entity> {
@nonNull
String _getConstructor(final List<Field> fields) {
final columnNames = fields.map((field) => field.columnName).toList();
final constructorParameters = _classElement.constructors.first.parameters;
final constructorParameters = _classElement.constructors.first.parameters. where((f)=> columnNames.contains(f.name)).toList();
Copy link

@dgsc-fav dgsc-fav Dec 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this filtering does not allow to change a column name in the ColumnInfo to any except the original name of the field

dgsc-fav pushed a commit to dgsc-fav/floor that referenced this pull request Dec 8, 2019
@vitusortner
Copy link
Collaborator

Closed by #248

@cassioseffrin
Copy link
Contributor

@Ghomi-Dev do you know when this feature @transient will be release. Next version?

@mqus
Copy link
Collaborator

mqus commented Apr 16, 2020

@ignore annotations are available since v0.11.0 and should perform the exact same function.
https://github.com/vitusortner/floor#ignoring-fields
(IMHO, @ignore is a better name than @transient)

@cassioseffrin
Copy link
Contributor

@mqus, I am a hibernate user, so I still confusing the annotations names. Thks @ignore will be very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants