Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore specific fields of entities #216

Closed
wants to merge 2 commits into from

Conversation

zzd258147
Copy link

Hi @vitusortner,

This is for #12 and #135 , please help to review these codes.

Thanks!

@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #216 into develop will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #216      +/-   ##
===========================================
+ Coverage    78.65%   78.66%   +<.01%     
===========================================
  Files           50       50              
  Lines         1415     1425      +10     
===========================================
+ Hits          1113     1121       +8     
- Misses         302      304       +2
Impacted Files Coverage Δ
floor_generator/lib/misc/constants.dart 15.15% <0%> (-0.48%) ⬇️
...loor_generator/lib/processor/entity_processor.dart 77.77% <100%> (+0.16%) ⬆️
floor_generator/lib/processor/field_processor.dart 85.29% <100%> (+3.15%) ⬆️
floor_generator/lib/value_object/field.dart 64% <33.33%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ce95e1...ee745e0. Read the comment docs.

@vitusortner
Copy link
Collaborator

@zzd258147 awesome contribution! I'll review and report back as soon as possible!

@vitusortner
Copy link
Collaborator

Closed by #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants