Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Analyzer 4 #659

Closed
fnicastri opened this issue May 27, 2022 · 8 comments · Fixed by #662
Closed

Support Analyzer 4 #659

fnicastri opened this issue May 27, 2022 · 8 comments · Fixed by #662
Assignees
@ThomasMiddel

Comments

@fnicastri
Copy link

Upgrade analyzer to v 4 please
@Amir-P
Copy link

Amir-P commented May 29, 2022

You can use this fork for now: https://github.com/Amir-P/flat. I've added support for Analyzer 4. @fnicastri

@fnicastri
Copy link
Author

@Amir-P Thanks!

@MrCsabaToth
Copy link

Badly needed!

@vitusortner
Copy link
Collaborator

we're working on support for analyzer 4 and we're expecting to ship a new release in the coming days.

@vyendn3
Copy link

vyendn3 commented Jun 11, 2022

Looking for update

@dkaera
Copy link
Collaborator

dkaera commented Jun 15, 2022 •
edited
Loading

Hey guys, long time no see 😄
Pushed a migration PR here
But I have no idea how to solve the resulting CI errors.
All tests are passing well, but test_cov throws an error. @vitusortner can you help to solve it, please?

@ThomasMiddel ThomasMiddel self-assigned this Jun 15, 2022
@ThomasMiddel
Copy link
Contributor

Hey all! I'm currently collaborating with Vitus to get Floor up and running again, I opened a PR to support analyzer 4.1.0 and fixed the CI issues just now. The idea is to get this merged ASAP and roll out an update within a couple of days.

Thanks for the contribution @dkaera! I'll check out the PR together with Vitus, maybe there's some stuff we can use there that we did differently 🙏

@dkaera
Copy link
Collaborator

dkaera commented Jun 16, 2022

Thanks, @ThomasMiddel 👍
So let's push this project 😄

@vitusortner vitusortner linked a pull request Jun 16, 2022 that will close this issue
Update Analyzer to 4.1.0 (#659) #662
Merged
vitusortner pushed a commit that referenced this issue Jun 17, 2022
@ThomasMiddel
Update Analyzer to 4.1.0 (#659) (#662)
ba521e3 
* Update to analyzer 4.1.0 and update to Flutter 3

* Fix tests where type from string were returned as function

* Fix remaining tests

* Use dart formatting

* Update MacOS action to use x64 Flutter version

* Update analyzer version of example project

* Simplify getting enum index

* Use reflection to access name and index

* Update flutter action version of example ci

* Make analyzer version less strict
@MrCsabaToth MrCsabaToth mentioned this issue Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasMiddel ThomasMiddel

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Analyzer to 4.1.0 (#659) pinchbv/floor
7 participants
@MrCsabaToth @dkaera @fnicastri @Amir-P @vitusortner @ThomasMiddel @vyendn3