Skip to content

Commit

Permalink
Add TODO #94 for SQL parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
vitusortner committed May 8, 2020
1 parent 880d2fa commit 0bd4f29
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@ abstract class AppDatabase extends FloorDatabase {

You can then query the view via a DAO function like an entity.

**NOTE:**
Be aware that it is currently not possible to return a `Stream` object from a function which queries a database view.
#### Limitations
- Be aware it is currently not possible to return a `Stream` object from a function which queries a database view.

## Data Access Objects
These components are responsible for managing access to the underlying SQLite database and are defined as abstract classes with method signatures and query statements.
Expand Down
4 changes: 2 additions & 2 deletions floor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@ abstract class AppDatabase extends FloorDatabase {

You can then query the view via a DAO function like an entity.

**NOTE:**
Be aware that it is currently not possible to return a `Stream` object from a function which queries a database view.
#### Limitations
- Be aware it is currently not possible to return a `Stream` object from a function which queries a database view.

## Data Access Objects
These components are responsible for managing access to the underlying SQLite database and are defined as abstract classes with method signatures and query statements.
Expand Down
2 changes: 1 addition & 1 deletion floor/lib/src/adapter/query_adapter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class QueryAdapter {
final String sql, {
final List<dynamic> arguments,
}) async {
// TODO differentiate between different query kinds (select, update, delete, insert)
// TODO #94 differentiate between different query kinds (select, update, delete, insert)
// this enables to notify the observers
// also requires extracting the table name :(
await _database.rawQuery(sql, arguments);
Expand Down

0 comments on commit 0bd4f29

Please sign in to comment.