Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Django <=1.10 support #57

Merged
merged 6 commits into from
Jan 20, 2018
Merged

Drop Django <=1.10 support #57

merged 6 commits into from
Jan 20, 2018

Conversation

grahamu
Copy link
Contributor

@grahamu grahamu commented Jan 11, 2018

Add namespacing to context_urls.py, remove patterns use.
Remove compat.py.
Add "PINAX_TEAMS" AppConf prefix for all settings.
Expand documentation.
Fix migration on_delete for null=True fields.
Update test configuration

Add namespacing to context_urls.py, remove `patterns` use.
Remove compat.py.
Add "PINAX_TEAMS" AppConf prefix for all settings.
Expand documentation.
Fix migration `on_delete` for null=True fields.
Update test configuration
@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #57 into master will decrease coverage by 1.46%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #57      +/-   ##
=========================================
- Coverage   49.17%   47.7%   -1.47%     
=========================================
  Files          19      16       -3     
  Lines         728     698      -30     
  Branches       77      76       -1     
=========================================
- Hits          358     333      -25     
+ Misses        363     359       -4     
+ Partials        7       6       -1
Flag Coverage Δ
#py27dj110 ?
#py27dj111 47.7% <27.27%> (-1.2%) ⬇️
#py27dj18 ?
#py34dj110 ?
#py34dj111 47.7% <27.27%> (-1.2%) ⬇️
#py34dj18 ?
#py34dj20 47.7% <27.27%> (-1.2%) ⬇️
#py35dj110 ?
#py35dj111 47.7% <27.27%> (-1.2%) ⬇️
#py35dj18 ?
#py35dj20 47.7% <27.27%> (-1.2%) ⬇️
#py36dj111 47.7% <27.27%> (-1.2%) ⬇️
#py36dj20 47.7% <27.27%> (-1.2%) ⬇️
Impacted Files Coverage Δ
pinax/teams/forms.py 42.85% <0%> (ø) ⬆️
pinax/teams/middleware.py 0% <0%> (ø) ⬆️
pinax/teams/context_urls.py 0% <0%> (ø) ⬆️
pinax/teams/hooks.py 80.95% <100%> (ø) ⬆️
pinax/teams/models.py 67.74% <100%> (ø) ⬆️
pinax/teams/templatetags/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6957e48...3b26cc6. Read the comment docs.

@grahamu
Copy link
Contributor Author

grahamu commented Jan 11, 2018

@paltman and/or @jacobwegner I'd appreciate your eyes on this PR bringing pinax-teams up to date with our latest supported Django/Python configurations. I believe this will resolve PRs #36 and #55. I'm also a bit leery of my updated requirement for django-reversion in light of #33 and #56 because I do not understand Jake's comment "breaks semantic versioning".

@paltman
Copy link
Contributor

paltman commented Jan 12, 2018

I'd be in favor of dropping django-reversion and letting the site builder decide how they want to version things, assuming that is possible to do with external packages.

@grahamu
Copy link
Contributor Author

grahamu commented Jan 20, 2018

@paltman and @jacobwegner after weighing pros and cons about removing django-reversion, I have decided to keep that requirement in place for the initial Django v2.0-compatible release. This gives existing users who rely on django-reversion a path forward with Django 2.0.

Later, after a bit of testing to find user-installed alternatives, we should remove django-reversion.

@grahamu grahamu merged commit a99c89d into master Jan 20, 2018
@grahamu grahamu deleted the django-20 branch January 20, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants