-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Django <=1.10 support #57
Conversation
Add namespacing to context_urls.py, remove `patterns` use. Remove compat.py. Add "PINAX_TEAMS" AppConf prefix for all settings. Expand documentation. Fix migration `on_delete` for null=True fields. Update test configuration
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=========================================
- Coverage 49.17% 47.7% -1.47%
=========================================
Files 19 16 -3
Lines 728 698 -30
Branches 77 76 -1
=========================================
- Hits 358 333 -25
+ Misses 363 359 -4
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
@paltman and/or @jacobwegner I'd appreciate your eyes on this PR bringing pinax-teams up to date with our latest supported Django/Python configurations. I believe this will resolve PRs #36 and #55. I'm also a bit leery of my updated requirement for |
I'd be in favor of dropping django-reversion and letting the site builder decide how they want to version things, assuming that is possible to do with external packages. |
@paltman and @jacobwegner after weighing pros and cons about removing django-reversion, I have decided to keep that requirement in place for the initial Django v2.0-compatible release. This gives existing users who rely on django-reversion a path forward with Django 2.0. Later, after a bit of testing to find user-installed alternatives, we should remove django-reversion. |
Add namespacing to context_urls.py, remove
patterns
use.Remove compat.py.
Add "PINAX_TEAMS" AppConf prefix for all settings.
Expand documentation.
Fix migration
on_delete
for null=True fields.Update test configuration