-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test python 3.8 and Django 3.0 #94
Conversation
Aligns the doc specs to match tested versions
README.md
Outdated
1.11 | * | * | * | * | ||
2.x | * | * | * | * | ||
3.0 | | * | * | * | ||
Django \ Python | 3.6 | 3.7 | 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KatherineMichel why the swap of slash direction here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have accidentally copied it from someplace that had it backwards.
@KatherineMichel Is the plan to have this in the next release? |
@hamstap85 Yes, it will be. We are close to merging a PR for an app that is a dependency for a number of other apps. I've been waiting for that to be done before moving forward. pinax/django-user-accounts#322 |
Tox had been working fine for me, it looks like you got the configuration to work on pre-existing environments |
@hamstap85 You have gotten all green? |
@KatherineMichel Interesting, not now. I'm not sure what was happening before. I'll look into it. |
It appears to be something fundamental to running tests is 2.2 and 3.0, because it's fine on |
@hamstap85 I'm wondering if it has to do with what @meshy encountered and provided some guidance for in PR linked below. By the way, @hamstap85 we have other apps that need to be updated as part of our new release. If you are interested in working on another one, let me know. We've got some in process. Others not started yet. #89 |
@@ -477,6 +488,11 @@ urlpatterns = [ | |||
|
|||
### 6.0.0 | |||
|
|||
* Drop Django 1.11, 2.0, and 2.1, and Python 2,7, 3.4, and 3.5 support | |||
* Add Django 2.2 and 3.0, and Python 3.6, 3.7, and 3.8 support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a request, and I hope it's not unreasonable of me.
Please don't drop 1.11 support until the release after you have introduced 2.2 support. By having a versions that supports two LTS versions at once, you greatly ease the life of people on an upgrade path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to approach that. The guidance to me from the person above me is to only include in a release versions of Python/Django that are officially supported. The reason why I dropped 1.11 is because the EoL is April. There are over 20 apps that were included in the last Pinax release. A release is a massive task and there is very little contribution to make it happen. It may still be in process by the EoL date in April and it's not likely there will be another one soon after. This app is also a problem app and I don't think can be released anyway, because the tests do not pass at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I don't want to derail your release process, or add undue pressure.
@KatherineMichel I'm sorry I haven't done much on this lately, been having to focus more of my attention on other stuff lately. It hasn't completely dropped from my radar though. |
@hamstap85 That's great. Thank you for letting me know. I'm not sure how to fix it myself, atm. |
@hamstap85 My computer broke, I got a new one and I'm happy to say the really bad error went away. I think maybe it had to do with the version of sqlite3 I had on my older computer. Not sure, but everything is green now. :) |
@KatherineMichel LOL my work machine also has battery bulging problems, so this has been low priority while getting everything else transitioned. I should be able to pull and test again soon. |
Aligns the doc specs to match tested versions
Changes proposed in this PR:
We're trying to upgrade to Django 3.0 as soon as possible, so I'm going through all our dependencies and helping ensure they work on the latest version of everything.