Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.2 and fix tests #369

Closed
wants to merge 10 commits into from
Closed

Conversation

blag
Copy link
Collaborator

@blag blag commented Sep 6, 2023

Closes #354, but also does more.

This PR is prep for a release. I'd like to get CI passing before I submit a PR to bump the version as part of a release.

Changes proposed in this PR:

  • Move accounts/tests to ./tests (so we don't distribute tests with package)
  • Use timezone-aware now() in middleware
  • Fix tests
  • Use ruff
  • Drop Django 2.2, and Python 3.6 and 3.7
  • Update GHA config

Tips for an ideal PR

@blag
Copy link
Collaborator Author

blag commented Sep 6, 2023

Not sure how to use GHA and turn off DeepSource. 😕

@uhurusurfa
Copy link
Collaborator

You would have to raise the PR from a branch within the repo to stop Deepsource running.

What is replacing the purpose that deepsource p[rovides?

@blag
Copy link
Collaborator Author

blag commented Sep 6, 2023

Gotcha, thanks, I'm not familiar with DeepSource. I was only removing it because I didn't recognize it, it was added 4 years ago, and I saw another PR that used GHA.

I'll close this and open another PR from within the repo.

@blag blag closed this Sep 6, 2023
@blag blag mentioned this pull request Sep 6, 2023
@uhurusurfa
Copy link
Collaborator

GHA does not currently offer any builtin functionality that I am aware of to do code analysis.
Leave deepsource in and fix any reported isues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: can't compare offset-naive and offset-aware datetimes While cheching account is expred
2 participants