Fix flash writes with Presto display active. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBell
commented
Nov 28, 2024
| // There can only be one presto display, so have a global pointer | ||
| // so that core1 can access it. Note it also needs to be in the | ||
| // Micropython object to prevent GC freeing it. | ||
| static ST7701 *presto; |
There was a problem hiding this comment.
This is slightly sad but seemed the simplest approach.
There was a problem hiding this comment.
I think we still have some of this pattern knocking about, if it works it works!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to execute code from flash on core1 while flash writes were happening. I think (hope!) this is the cause of all the weird instability, I've tried initializing wifi and the display in different orders and that does seem to be working.