Fixes for PNGDEC on Badger 2040 / Badger 2040 W #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've run through some tests rendering PNGs on Badger 2040 W with these changes. Tried what I hope are 1bit, 2bit, 4bit and 8bit indexed plus RGB with the desired results. Ignore the...weirdness of these test images, I missed the "include unused colours" tickbox in GiMP's colour conversion dialog and uh, got creative.... 1bpp 2bpp 4bpp 8bpp rgb rgb Note: In all cases these will be crushed to 1bit since Badger 2040 is monochrome only, but RGB or higher colour depths should use the 16 step dithering patterns. The most obvious way to see this in effect is the RGB badgerpunk full screen image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes are required for PNGDEC to function correctly on Badger 2040 and Badger 2040 W, so it can be added - pimoroni/badger2040#75
The fix to
PicoGraphics_Pen1BitY::set_pencorrects handling of RGB and ARGB PNGs.The fix to PNGDEC adds explicit support for 1bit PNGs, which would obviously be desirable on a 1bit display.