Allow pen function for fast tile alpha blending #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBell
commented
Sep 8, 2023
| @@ -293,6 +293,8 @@ namespace pimoroni { | |||
| virtual void frame_convert(PenType type, conversion_callback_func callback); | |||
| virtual void sprite(void* data, const Point &sprite, const Point &dest, const int scale, const int transparent); | |||
|
|
|||
| virtual bool render_pico_vector_tile(const Rect &bounds, uint8_t* alpha_data, uint32_t stride, uint8_t alpha_type) { return false; } | |||
There was a problem hiding this comment.
Not sure if it would be preferable to expose the pretty_poly antialias type here instead of having magic numbers that match that enum?
There was a problem hiding this comment.
Have to be careful about too tightly coupling PicoGraphics and PicoVector since it's entirely possible to have C++ or MicroPython builds that include the former but not the latter. In this case perhaps it's PicoGraphics that should define the enum type for anti-aliasing so that PicoVector can inherit it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a hook to allow the pen implementation to provide a fast alpha blend for a picovector tile.