Rewrite the Tufty2040 main menu somewhat #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily motivated to get almost everything out of globals and fix issue pimoroni#631. This is a stripped-down version of the gist there without the memory debugging and reboot-into-direct-boot mode. Mostly move things to functions. Clean up some dead code and comments. I think the biggest win is not actually the PicoGraphics framebuffer, which is well-behaved, but random temporary floats that were leaking previously. Also type-annotated and lints clean. Fixes pimoroni#631. (As much as I think is possible.)
Gadgetoid
added
the
[- tufty2040 -]
|
Thank you! Just given this a test - seems to be working nicely for me with all our examples :) |
|
If it passes CI, I'm happy 😄 Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily motivated to get almost everything out of globals and fix issue #631. This is a stripped-down version of the gist there without the memory debugging and reboot-into-direct-boot mode.
Mostly move things to functions. Clean up some dead code and comments. I think the biggest win is not actually the PicoGraphics framebuffer, which is well-behaved, but random temporary floats that were leaking previously.
Also type-annotated and lints clean.
Fixes #631. (As much as I think is possible.)