Fix: Properly implement non-blocking update functions for the Inky Frame #1042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tinkering with my Inky Frame, I noticed that changing the blocking parameter of InkyFrame::update to false has no effect. To be more specific, this is the code I was running (I wanted the status LED to softly pulse while updates are happening to the e-ink display):
It turns out that the blocking parameter was being completely ignored in both the inky_frame and inky_frame_7 source files. Thus, I have made a few simple fixes to make the code respect the blocking flag. Also, in inky73.cpp, busy_wait() was called whether or not blocking was set to true or false. I have removed the extra function call.
These fixes appear to make the code provided above run properly, at least on my Inky Frame 7.3".