PicoVector 2 text word wrap and transform #1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add preliminary support for multiple layered drawing surfaces. Allows, for example, static content to be loaded into one layer and remain unmodified while the above layer contains animations. Particularly useful for drawing PNG or JPEG UI elements which are then overdrawn with text or animated elements, without paying the cost of loading/decoding every frame.
Ignore sign compare and narrowing conversion errors in pretty-poly.h.
Pointers were being incremented as if they were bytes, rather than larger containers.
pretty-poly.h is not giving us fully clipped rectangles, so revert to the slower bounds checked pixel for now.
* Remove Polygon types in favour of primitives .circle, .rectangle etc * Add a new Transform type for building up transformation matrices * Add support to set/clear transform on drawing
Drop dependence on null terminated strings, and for a final linebreak. Bound all text processing using the text length.
For both APA102 and WS2812 the pins used on the same PIO must be in the same range. The GPIO base offset applies to the whole PIO and not individual state machines. This means that for APA102 both data and clock must be in the same pin range, ie: either 16-48 inclusive or 0-31 inclusive.
MichaelBell
changed the title
MichaelBell
commented
Nov 17, 2024
| @@ -51,7 +51,7 @@ int main() { | |||
| pp_mat3_translate(&pos, 50, 50); | |||
| pp_mat3_rotate(&pos, a); | |||
| vector.draw(poly); | |||
| vector.text("Hello World", &pos); | |||
| vector.text("Hello World", 0, 0, &pos); | |||
There was a problem hiding this comment.
Alternatively could make these optional arguments if you prefer - I had kind of forgotten that this was also exposed to C++.
There was a problem hiding this comment.
I think it would be good to make these optional, since it also bubbles up to Python. C isn't super helpful about that, though. I wonder if it makes sense to have them part of the text metrics, or if that's just too conceptually weird.
Sensible API design for this has been quite tricky!
MichaelBell
commented
Nov 17, 2024
| //pp_mat3_t t = pp_mat3_identity(); | ||
| //vector.text("Hello World", {0, 0}, &t); | ||
| pp_mat3_t t = pp_mat3_identity(); | ||
| vector.text("Hello World", 0, 0, &t); |
There was a problem hiding this comment.
Possibly uncommenting this was unwise as I don't have one of these to test. I got confused between this and the new RP2350 based explorer 😆
Gadgetoid
force-pushed
the
feature/picovector2-and-layers
branch
2 times, most recently
from
633d387 to
f4409d8
Compare
Gadgetoid
force-pushed
the
feature/picovector2-and-layers
branch
2 times, most recently
from
01d8aa7 to
762c5cb
Compare
|
Okay I think I merged this into #1019 and forgot. Closing for now and we can deal with any warts as they pop up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements to the PicoVector 2 text support: