Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error in docs #14

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fixed error in docs #14

merged 1 commit into from
Dec 17, 2024

Conversation

topshed
Copy link
Contributor

@topshed topshed commented Dec 13, 2024

I think the docs are still a little confusing here. Perhaps the original author intended these examples to be

rgb = tiny.rgb
rgb.set_rgb(255,0,0)

etc

but this then inconsistent with the rest of the docs, which all use tiny.

@ZodiusInfuser ZodiusInfuser merged commit 82ee19d into pimoroni:main Dec 17, 2024
6 checks passed
@ZodiusInfuser
Copy link
Member

Hi @topshed. Thank you for this!

I forget my original intent, so it's either what you suspect, or I may have had set_rgb be a function on the tiny_fx object at some point but then removed it and forgotten to update the documentation.

@ZodiusInfuser
Copy link
Member

Hmm. Actually, It does seem my intent was

rgb = tiny.rgb
rgb.set_rgb(255,0,0)

As using tiny.rgb. all the time is unnecessarily tedious.

Oh well. I've merged your change in now. I may edit it in the future if I remember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants