Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions to resolve vulnerabilities #89

Merged

Conversation

jakecyr
Copy link
Contributor

@jakecyr jakecyr commented Dec 29, 2022

Overview

Update package versions to resolve most of the ~44 npm audit high vulnerabilities (except for 1) and replace istanbul in favor of the succeeding nyc.

Testing

Tested by running all unit tests and executing the functions with test data to make sure they return the expected data.

@jakecyr jakecyr changed the title Update package versions to resolve vulnerabilities and replace istanbul in favor of the succeeding nyc Update package versions to resolve vulnerabilities Dec 29, 2022
@gadicc
Copy link
Collaborator

gadicc commented Dec 29, 2022

Thanks, @jakecyr. This is great!!

@pilwon, LGTM... happy to take care of this if you don't have any comments.

@jakecyr
Copy link
Contributor Author

jakecyr commented Dec 29, 2022

Thanks, @jakecyr. This is great!!

@pilwon, LGTM... happy to take care of this if you don't have any comments.

Happy to help! Let me know if you would like any changes.

@gadicc gadicc merged commit 0c77c4d into pilwon:master Jan 5, 2023
@gadicc
Copy link
Collaborator

gadicc commented Jan 5, 2023

Merged and published as v0.3.8 on npm and github.

Thanks so much, @jakecyr... this was a very welcome and high quality PR!

Hope you've also seen some of the work continuing at https://github.com/gadicc/node-yahoo-finance2.

@jakecyr
Copy link
Contributor Author

jakecyr commented Jan 5, 2023

published as v0.3

Thank you @gadicc! I'm happy to help.

I did not, but I'll check that out and would love to contribute more if needed!

@jakecyr jakecyr deleted the update-packages-to-prevent-vulnerabilities branch January 5, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants