Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote() - multiple symbols & options sanitization #47

Merged
merged 3 commits into from
Sep 25, 2017

Conversation

gadicc
Copy link
Collaborator

@gadicc gadicc commented Sep 21, 2017

Hey @pilwon, as per comments in #42, I've separated out the work on the above. I'd prefer to leave the final "3/3" pull request open to track the rest of the work there, until I'm fully happy with it. Quite regrettably, as mentioned there (and evident by my github history), a lot of unexpected commitments came my way this year. Nevertheless I hope to have some time to finally finish this off next week, but wanted to at least separate this out while I had a chance today.

@pilwon
Copy link
Owner

pilwon commented Sep 25, 2017

Thanks @gadicc! This is great. I left the other PR open for you. Thank you for sparing your valuable time to finish up the work on top of awesome work you've already done for yahoo-finance!

@pilwon pilwon merged commit ce136a3 into pilwon:master Sep 25, 2017
@pilwon
Copy link
Owner

pilwon commented Sep 25, 2017

Published as v0.3.3

@gadicc
Copy link
Collaborator Author

gadicc commented Sep 25, 2017

Thanks, @pilwon! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants