Improve prefix behavior with non-segment params #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
force-pushed
the
path-segment-suffix-patch
branch
from
f73ccd1 to
3902509
Compare
blakeembrey
force-pushed
the
path-segment-suffix-patch
branch
from
3902509 to
876222c
Compare
paulmelnikow
added a commit
to paulmelnikow/path-to-regexp
that referenced
this pull request
Dec 5, 2018
Thanks so much for this library! It’s come in very handy in Shields. We’ve significantly reduced the duplication in our route definitions, and we’re getting really close letting developers build badge URLs in the frontend. We’re running into an issue when an optional token precedes the extension. Many of the routes look something like this: `/travis/:user/:repo/:branch?.ext(svg|png)` - That pattern matches `/travis/foo/bar/master.svg` as we’d expect - Unexpectedly it _does not_ match `/travis/foo/bar.svg` - Unexpectedly it _does_ match `/travis/foo/bar/.svg` I traced the behavior back to pillarjs#71 where it was introduced. I _think_ it was unintentional since that PR was about making the leading delimiter optional for an optional token. I don’t see why the delimiter should be present before an optional in the middle. It’s kind of an odd fix, though it makes some sense given pillarjs#71 was about fixing leading optionals.
paulmelnikow
added a commit
to paulmelnikow/path-to-regexp
that referenced
this pull request
Dec 5, 2018
Thanks so much for this library! It’s come in very handy in Shields. We’ve significantly reduced the duplication in our route definitions, and we’re getting really close letting developers build badge URLs in the frontend. We’re running into an issue when an optional token precedes the extension. Many of the routes look something like this: `/travis/:user/:repo/:branch?.ext(svg|png)` - That pattern matches `/travis/foo/bar/master.svg` as we’d expect - Unexpectedly it _does not_ match `/travis/foo/bar.svg` - Unexpectedly it _does_ match `/travis/foo/bar/.svg` I traced the behavior back to pillarjs#71 where it was introduced. I _think_ it was unintentional since that PR was about making the leading delimiter optional for an optional token. I don’t see why the delimiter should be present before an optional in the middle. It’s kind of an odd fix, though it makes some sense given pillarjs#71 was about fixing leading optionals. @RedSparr0w was asking about paths like `/:optional?/:required.json` so I added another test example to the test for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70