Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backtrack protection to 6.x #324

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

blakeembrey
Copy link
Member

@blakeembrey blakeembrey commented Sep 12, 2024

Closes #323. It will likely break some existing routes around the edge cases, but it should eliminate the vulnerability when the pattern isn't specified.

@blakeembrey blakeembrey changed the base branch from master to 6.x September 12, 2024 00:27
@blakeembrey blakeembrey force-pushed the be/6.x-backtrack-protection branch from bf0365b to b891ab9 Compare September 12, 2024 00:28
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 95.61%. Comparing base (28a5b27) to head (a1cfa60).

Files with missing lines Patch % Lines
redos.ts 0.00% 20 Missing and 1 partial ⚠️
src/index.ts 74.07% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               6.x     #324      +/-   ##
===========================================
- Coverage   100.00%   95.61%   -4.39%     
===========================================
  Files            1        2       +1     
  Lines          621      662      +41     
  Branches       140      145       +5     
===========================================
+ Hits           621      633      +12     
- Misses           0       28      +28     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakeembrey blakeembrey merged commit f1253b4 into 6.x Sep 12, 2024
4 checks passed
@blakeembrey blakeembrey deleted the be/6.x-backtrack-protection branch September 12, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply backtrack protection to version 6.x because of @koa/router
1 participant