Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Audit Version Bump #279

Merged
merged 1 commit into from
May 26, 2022
Merged

Conversation

Segmentational
Copy link
Contributor

@Segmentational Segmentational commented May 23, 2022

Hello,

Big fan of the pillarjs organization, btw! Keep on making the world a better place :D


The following pull request is relating to that pesky minimist security concern; changes are only to the package-lock.json.

All tests passed successfully.


Edit* -- oh yes, I also updated, implicitly @typescript-eslint/eslint-plugin to 5.25.0.

As a recommendation, I do suggest setting that explicitly as a devDependency. I was previously working in a lerna monorepo, which is why it got caught in the package-lock.

If this is of any concern, which it's still passing tests, let me know and I'll close + submit a new PR.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #279 (b4a4351) into master (b0778f5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          248       248           
  Branches        98        98           
=========================================
  Hits           248       248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0778f5...b4a4351. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants