-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore .spec.ts files when compiling #220
Conversation
To be clear, it looks like the problem is that we are publishing the spec file. This can also be solved in a different way, where test files are in a specific |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonchurch!
Dumb question, but can we use the NPM config to ignore these files? Last I recall you couldn't combine |
Grrr, I've written, rewritten, and deleted this comment several times now. I'm not having any luck actually with |
@jonchurch Thanks for exploring! Sorry to put you through that. Let's merge and we can release as is. |
Thanks to @StephenTangCook for asking the question! |
We may need to revert this or do additional work. I realized the other week that by excluding these files, it’s not actually using the right settings for type checking. Not a problem right now, but we should probably have a specific build config instead of changing this one. |
Relates to #219
Assuming the
.spec.ts
file are not intended to be part of the distribution, they should be ignored when compiling.