Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unpipe package and use native unpipe method #66

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Phillip9587
Copy link
Contributor

The unpipe package was used to unpipes all destinations from a given stream.

Taken from the unpipe readme:

With stream 2+, this is equivalent to stream.unpipe(). When used with streams 1 style streams (typically Node.js 0.8 and below), this module attempts to undo the actions done in stream.pipe(dest).

As our minimum supported Node version is v18 the unpipe package is no longer needed.

@Phillip9587
Copy link
Contributor Author

Hi @wesleytodd, I hope you're doing well! I just wanted to kindly follow up on this PR. I added a entry in the HISTORY.md and believe it’s ready to merge now.

If there’s anything else needed on my end, please let me know. Thank you for your time and consideration!

@wesleytodd
Copy link
Member

No action necessary on your end. I have just been catching up and trying to balance this work with my other commitments and have not had time to put together releases for these packages yet. It will happen though, just takes time.

@wesleytodd wesleytodd merged commit d40ca85 into pillarjs:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants