add features into showMultiLinePlots.R and showMultiLinePlotsByVariable.R #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cchrisgong
commented
Feb 7, 2024
cchrisgong
commented
- add options for multiple rows of subfigures for regional line plot in both
- for showMultiLinePlotsByVariable.R, add an option to show or not show global plot (to save space)
added 4 commits
February 5, 2024 17:32
…ultiLinePlots and showMultiLinePlotsByVariable.R
pfuehrlich-pik
suggested changes
Feb 7, 2024
R/showMultiLinePlots.R
Outdated
| @@ -27,6 +28,7 @@ | |||
| #' @importFrom ggplot2 ylim | |||
| showMultiLinePlots <- function( | |||
| data, vars, scales = "free_y", | |||
| NROW_NUM = 1, | |||
There was a problem hiding this comment.
Suggested change
| NROW_NUM = 1, | |
| nrowNum = 1, |
This argument name would be more in line with our camelCase naming convention
R/showMultiLinePlotsByVariable.R
Outdated
| @@ -92,39 +97,46 @@ showMultiLinePlotsByVariable <- function( | |||
|
|
|||
| label <- paste0("(", paste0(levels(d$unit), collapse = ","), ")") | |||
| xLabel <- paste0(xVar, " (", paste0(levels(d$unit.x), collapse = ","), ")") | |||
|
|
|||
|
|
|||
| if (showGlobal) { | |||
| p1 <- dMainScen %>% | |||
There was a problem hiding this comment.
Please double check the indentation here, I think this needs to be indented more because you added the if
R/showMultiLinePlotsByVariable.R
Outdated
| if (showHistorical) { | ||
| stopifnot(xVar %in% names(histRefModel)) | ||
| if (showGlobal) { | ||
| p1 <- p1 + |
There was a problem hiding this comment.
please check indentation
R/showMultiLinePlotsByVariable.R
Outdated
| p2 <- p2 + | ||
| geom_point(data = dRegiHist, aes(shape = .data$model)) + | ||
| geom_line(data = dRegiHist, aes(group = paste0(.data$model, .data$region)), alpha = 0.5) | ||
| } | ||
| # Add markers for certain years. | ||
| if (length(yearsByVariable) > 0) { | ||
| if (showGlobal) { | ||
| p1 <- p1 + |
There was a problem hiding this comment.
please check indentation
R/showMultiLinePlotsByVariable.R
Outdated
| @@ -134,8 +146,10 @@ showMultiLinePlotsByVariable <- function( | |||
| } | |||
|
|
|||
| # Show plots. | |||
| if (showGlobal) { | |||
| print(p1) | |||
There was a problem hiding this comment.
please check indentation
added 2 commits
February 7, 2024 17:06
pfuehrlich-pik
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.