Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Convergence Plot #81

Merged
merged 20 commits into from
Nov 6, 2023
Merged

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Oct 26, 2023

Removes the REMIND convergence plot, as mip was originally meant as an application independent visualization package.

@fbenke-pik fbenke-pik marked this pull request as draft October 26, 2023 12:29
@fbenke-pik fbenke-pik changed the title remove no longer needed code Enhance Convergence Plot Oct 27, 2023
Copy link
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, a bit late for asking this: are we sure that this funciton should be in the mip-package? As we are using some specific variable names, maybe it should go to remind2?

@fbenke-pik
Copy link
Contributor Author

You can argue either way. If you stress the visualization aspect, it goes into mip. If you stress the aspect of coding of GAMS logic and variables in R, it goes into remind2.

@LaviniaBaumstark
Copy link
Member

Let's keep it here for now

@tscheypidi
Copy link
Member

mip was originally meant as an application independent visualization package. From that perspective these specific functions violate this definition. But I also have to say that its been a while that I had a look at the package. So there might be already violations in there?

@orichters
Copy link
Contributor

I'm sorry, but I don't really know what is going on here and don't have time to dig into it at the moment, so I let you find a good solution…

@orichters orichters removed their request for review November 6, 2023 10:03
@fbenke-pik fbenke-pik marked this pull request as ready for review November 6, 2023 10:26
@fbenke-pik fbenke-pik changed the title Enhance Convergence Plot Remove Convergence Plot Nov 6, 2023
@fbenke-pik
Copy link
Contributor Author

Deleting mipConvergence and moving it to remind2.

@fbenke-pik fbenke-pik merged commit 3344f78 into pik-piam:master Nov 6, 2023
2 checks passed
@fbenke-pik fbenke-pik deleted the convergence branch November 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants