-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Convergence Plot #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, a bit late for asking this: are we sure that this funciton should be in the mip-package? As we are using some specific variable names, maybe it should go to remind2
?
You can argue either way. If you stress the visualization aspect, it goes into mip. If you stress the aspect of coding of GAMS logic and variables in R, it goes into remind2. |
Let's keep it here for now |
mip was originally meant as an application independent visualization package. From that perspective these specific functions violate this definition. But I also have to say that its been a while that I had a look at the package. So there might be already violations in there? |
I'm sorry, but I don't really know what is going on here and don't have time to dig into it at the moment, so I let you find a good solution… |
Deleting mipConvergence and moving it to remind2. |
Removes the REMIND convergence plot, as mip was originally meant as an application independent visualization package.