Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plotstyle() does not strip units from variable names, based on strip_units argument or plotstyle.strip_units option #106

Merged
merged 4 commits into from
Jul 9, 2024
Merged

plotstyle() does not strip units from variable names, based on strip_units argument or plotstyle.strip_units option #106

merged 4 commits into from
Jul 9, 2024

Conversation

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

See #54 (comment)

Next steps:

  • add a warning triggered when units are actually stripped
  • ask everybody (mostly MAgPIE folks I guess) to look out for the warning and adjust their code
  • switch the default of plotstyle.strip_units to FALSE

@orichters
Copy link
Contributor

Please merge 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q#1 to make sure the plotting functions don't fail anymore.

@orichters
Copy link
Contributor

And thanks for preparing the fix!

orichters and others added 2 commits July 9, 2024 15:03
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q merged commit ffcf654 into pik-piam:master Jul 9, 2024
1 of 2 checks passed
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q deleted the dev/plotstyle_keep_units branch July 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklein-pik dklein-pik Awaiting requested review from dklein-pik

@orichters orichters Awaiting requested review from orichters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q @orichters