Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log messages for model_lock #76

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Improve log messages for model_lock #76

merged 1 commit into from
Oct 9, 2023

Conversation

orichters
Copy link
Contributor

old:

2023-09-29 22:09:37: acquiring model lock...
acquired model lock in 3.9 secs.

new:

2023-09-29 22:09:37: try to acquire model lock...
2023-09-29 22:09:41: acquired model lock in 3.9 secs.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c395010) 34.90% compared to head (f188569) 34.94%.

❗ Current head f188569 differs from pull request most recent head fdce8bd. Consider uploading reports for the commit fdce8bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   34.90%   34.94%   +0.03%     
==========================================
  Files          51       51              
  Lines        1693     1694       +1     
==========================================
+ Hits          591      592       +1     
  Misses       1102     1102              
Files Coverage Δ
R/model_lock.R 71.42% <100.00%> (+1.42%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orichters orichters merged commit df17599 into pik-piam:master Oct 9, 2023
2 checks passed
@orichters orichters deleted the lock branch January 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants