New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop empty module subfolders in getModules #101

Merged

orichters merged 1 commit into pik-piam:master from orichters:getmodules

Jul 11, 2024

Contributor

orichters commented Jul 10, 2024

if a module was renamed (as was the case with 29_ageclass -> 28_ageclass in MAgPIE) or deleted (as was the case with 30_crop in MAgPIE), but git does not delete the folder because of some input files lying around, the scripts fails
See for example REMIND's automated model tests: /p/projects/remind/modeltests/remind/tests/test-full-2024-07-09.log:

Error: Chosen realization "feb21" does not exist for module "ageclass"
Execution halted

With this PR: in getModules, drop folders that do not contain a single *.gms file (usually: module.gms), and raise a warning instead
For REMIND, after creating an empty 18_test folder and executing Rscript start.R -t, before and after this PR:

Error: Chosen realization "NULL" does not exist for module "test"

Warning message:
In getModules(modulepath = modulepath) :
  The following module folders contain no '*.gms' file and are ignored: 18_test

also fixes replace_in_file() does not name the file in which an error occured, impeding debugging #100


          drop empty module subfolders in getModules

c8576fa

orichters requested a review from tscheypidi

July 10, 2024 10:32

tscheypidi approved these changes

View reviewed changes

Member

tscheypidi left a comment

looks good, thanks

orichters merged commit 04d5e64 into pik-piam:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet