Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix histTimesteps & ICEban trucks, busses #270

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

johannah-pik
Copy link
Contributor

@johannah-pik johannah-pik commented Aug 12, 2024

This PR includes a bugfix to remove differences in historical timesteps (<= 2020) between scenarios.
The reason was the normalization of preferences, which was done only for scenarios, where mitigation factors were applied (mix2 upwards). Preference factors in 2015 were interpolated and thus changed.
Furthermore, I found a bug in the ICEban application. The hard-coded implementation refers to values in 2015 which are historical timesteps and not available in this part of the code.
To solve all the above-mentioned problems the steps were separated and now applied in the correct order:
-Bind historical timesteps and future scenario specific timesteps
-Interpolate
-Apply ICE ban
-Normalize

-> Output of Mix1 was compared to Mix4ICEban and showed no differences in historical timesteps.
-> Test fo NAs were included to prevent bug that occured in ICE ban application
-> Test to compare output of different scenarios and prevent changes in hist time steps will be integrated in advanced PR test routine of edgeTransport (integration of tests that require complete model runs in testthat not preferable as storing of large files like fulldata.gdx in the package would be necessary)

Before and after compScens are available here: /p/projects/edget/PRchangeLog/20240812_PR270_BugfixHistTImestepsAndICEbanBusTruck
Bug in ICEban application for trucks and busses had only minor impact

Copy link
Contributor

@orichters orichters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks somewhat plausible, but I don't really understand what is going on. :D

@johannah-pik johannah-pik merged commit e57d002 into pik-piam:master Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants