Add integration with piamPlotComparison for compareScenarios #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the generic logic to create a compareScenarios pdf to the library piamPlotComparison.
The following files are no longer needed:
R/compareScenarios_EDGET.R(moved to piamPlotComparison)inst/Rmd/compareScenarios_Transport/csEDGET_main.Rmd(moved to piamPlotComparison, EDGE-T specific code was moved toinst/compareScenarios/preprocessing.R)inst/Rmd/compareScenarios_Transport/cs2_latex_template.texandinst/Rmd/compareScenarios_Transport/cs_pdf_header_include.tex(moved to piamPlotComparison)inst/Rmd/compareScenarios_Transport/cs2_plot_functions.R(some functions were deleted as they were no longer used, others were moved to the notebook where they are used or to theinst/compareScenarios/preprocessing.R)The section markdowns used to generate the current pdf are EDGE-T specific and remain in this repo. To work with the new framework, they were moved to the folder
/inst/compareScenarios/and renamed tocs_NN_TEXT.Rmd(e.g.inst/Rmd/compareScenarios_Transport/csEDGET_01_energy_demand.Rmd->inst/compareScenarios/cs_01_energy_demand.Rmd).inst/compareScenarios/cs_06_costs_and_shareweight_trends.Rmdwas refactored to use dplyr instead of data.table. The output generated has not changed through this refactoring.Rmd files not used in the current cs2 plotting were left in the original folder
inst/Rmd/compareScenarios_Transport/. If they are no longer needed, they should be deleted.