Add noBan LSC scenarios #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the Mix2 scenario changed since September2023 and the LSC assumptions are relative to the reference scenario (Mix2), I changed the techScen and demScen factors to still follow the scenario protocol. Comparison between old and new runs:
…to newLowCampScen
To fulfill the requirements from E3M, I ajudsted the parameters in demscen and mitigation tech.csv. The result show that lsc_Strong, Weak and Low are more evenly distributed now. Especially, I ensrued, that lsc_Low is more ambitous than the previous version (E3M request). I changed for the navigate comparison script Mix1 to Mix2 as I understood this to be the new standard comparison techScenario.
The importFrom(magrittr,`%>%`) was necessary because piamInterfaces did not work with the previous version. The compScen can be found at 20240302_PR240_UpdateCampScens_2
…to newLowCampScen
Note that Mix2 is the reference for the LSC scenarios and not Mix3 or Mix4.
|
Could you change the delimiter in the csv files so that we can review the changes? |
johannah-pik
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of LSC scenarios without ICEban and a Mix2 with an ICEban.
Note that Mix2 is the reference for the LSC scenarios and not Mix3 or Mix4.
CompScen can be found here:
p/projects/edget/20240208_PR241_Add_noBan_LSC_scenarios