MAINT: fix Data.print_data_info()
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove printing `Dataset.file_format` for `h5netcdf` compatibility - alternatively introduce strict `netCDF4-python` dependency
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 60.72% 60.73%
=======================================
Files 44 44
Lines 6357 6356 -1
=======================================
Hits 3860 3860
+ Misses 2497 2496 -1 ☔ View full report in Codecov by Sentry. |
|
If there is no other reliance on the legacy API, then I agree that this is the best solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataset.file_formatforh5netcdfcompatibilitynetCDF4-pythondependencyA rather bold fix, but probably the easiest one. Could not find an alternative attribute to print instead of
file_format.Any objections?