-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add build jobs for macOS and Windows in travis.yml
#214
Conversation
060a796
to
b77056e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 60.72% 60.72%
=======================================
Files 44 44
Lines 6357 6357
=======================================
Hits 3860 3860
Misses 2497 2497 ☔ View full report in Codecov by Sentry. |
- and comment out linux job matrix for now
b77056e
to
f26445d
Compare
e2a0190
to
7609f9b
Compare
|
- and remove install options
- as adding to build matrix not working somehow
- found a typo in the choco install, try that one again now
- and put `path` in new line
This PR is becoming a bit of a mess, but I've run into multiple issues here. @ntfrgl, sorry for bothering you with it at this stage, but maybe you have a quick idea on what direction to proceed? I feel like I'm acting pretty clumsy on this, have no experience whatsoever with windows and/or git bash, don't want to waste too much time and credits... Relevant parts of Travis docs including examples: explicitly including jobs into build matrix, run travis on multiple os, the windows build environment i. combining the linux and macos jobsmacOS builds are running fine, although taking about 20 minutes which could be sped up maybe. Only I could not figure out how to expand the linux build matrix with a single macOS build (see 5145e49 for my most recent try). Therefore, in f66d3e3 I just added all linux jobs explicitly, which is not very elegant but works. ii. installing miniconda on windows vmI tried installing miniconda two ways:
now an alternative would be to go without conda and just pip instead, of course, but would then need to rewrite the everything for just the windows case. |
- with commands from example scripts
Finally got the Now
see build log for full error message. I checked for the |
Same problem occurs without conda, just using pip (see commit above). |
- consolidate build matrix - remove `language: python` - macOS: force GNU `sed` - Windows: pass `$WINDIR` into `tox`
- Tox: skip package installation inside venv (packaging & Cython have matured) - Travis: avoid `brew update`
@fkuehlein, thank you for getting all the tedious work done! This is a big step forward for the project. In my commits above, I resolved the remaining issues you mentioned, and achieved some simple speedups. |
Thank you lots, @ntfrgl! Great to see all green checks on this ... with the |
I will have to do this step-wise to see what works, as Travis CI documentation does not really cover our specific case. Will start with the macOS job, add a Windows job after that, and finally add the Linux jobs back again, hopefully not needing too many builds along the way.