Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graph): support of graph card #308

Merged
merged 17 commits into from
May 8, 2022
Merged

feat(graph): support of graph card #308

merged 17 commits into from
May 8, 2022

Conversation

acesyde
Copy link
Contributor

@acesyde acesyde commented Apr 14, 2022 •
edited by piitaya
Loading

#Fixes #74
image
image

@acesyde acesyde changed the title Feature/graph card feat(graph): support of graph card Apr 14, 2022
@piitaya
Copy link
Owner

piitaya commented Apr 14, 2022

Nice 🙂 What's the graph height ? It should be nice to have a 46px to have the size of the slider, buttons, etc...
Or we can propose an option to let the user choose the size : compact vs default.

What do you think ?

@acesyde acesyde marked this pull request as ready for review April 14, 2022 20:34
@acesyde
Copy link
Contributor Author

acesyde commented Apr 15, 2022

@piitaya ready to review

@ghost
Copy link

ghost commented Apr 16, 2022

@acesyde you are a champ!!!! supper work helping to add so much to the work @piitaya has done.. fantastic good you guys

@alessandroias
Copy link
Contributor

Wouldn't it be more in line with the rest of the cards if name and value were reversed?
In mushroom usually the primary_information is name of the card, while the secondary_information is the entity state. I hate to point this out, as I am eager to use this card in my dashboard.

alessandroias
alessandroias suggested changes Apr 21, 2022
View reviewed changes
docs/cards/graph.md Outdated Show resolved Hide resolved
alessandroias
alessandroias approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@alessandroias alessandroias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@piitaya piitaya added the enhancement New feature or request label Apr 22, 2022
@alessandroias
Copy link
Contributor

@piitaya what do you think about this?

@acesyde acesyde mentioned this pull request Apr 24, 2022
Closed
@piitaya piitaya changed the base branch from main to graph May 8, 2022 18:30
@piitaya
Copy link
Owner

piitaya commented May 8, 2022

I will merge it into a graph branch and test it before release 🙂

@piitaya piitaya merged commit 739bc35 into piitaya:graph May 8, 2022
@acesyde acesyde deleted the feature/graph_card branch May 8, 2022 18:40
@acesyde
Copy link
Contributor Author

acesyde commented May 8, 2022

Yes because it's not up to date 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahera Kahera Kahera left review comments

@alessandroias alessandroias alessandroias approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display state/attribute graph
4 participants
@acesyde @piitaya @alessandroias @Kahera