-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include_path vs include_paths #12
Comments
If I remember correctly, the rationale was that the C API has Possible options:
Which makes the most sense to you? I suspect 3 is the Julian way, as in the case of "one or many" the default is the plural. OTOH it may be not ideal to have |
Sorry for forgetting to reply to this. My feeling is that since the keyword is directly related to the I didn't read the C code, but looking at the C API, my hunch is that |
This is only a documentation change, bringing the docs in line with both the Julia implementation and the C API. Fix piever#12.
Makes sense, I also prefer changing the documentation rather than the implementation. Thanks for making the PR! |
This is only a documentation change, bringing the docs in line with both the Julia implementation and the C API. Fix #12.
For setting the include paths, the documentation
Sass.jl/src/julian_api.jl
Line 35 in f627a99
disagrees with the implementation
Sass.jl/src/julian_api.jl
Line 11 in f627a99
As
libsass
seems to haves
at the end, I guess the implementation should be changed to:include_paths => sass_option_set_include_paths
?The text was updated successfully, but these errors were encountered: