Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add mouse events for arrows #183

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

pierpo
Copy link
Owner

@pierpo pierpo commented Nov 6, 2022

Allows for clickable arrows, drag and droppable arrows...

@pierpo
Copy link
Owner Author

pierpo commented Nov 6, 2022

domAttributes is not super clear as a prop name. But I don't know what else to name it, I took this name from the official typescript type I took the properties from... 🤔

@pierpo pierpo added the enhancement New feature or request label Jul 25, 2023
Copy link

@fahimsweb fahimsweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest snapshots needs to be updated, shows a failed error. Hover example works well

@fahimsweb
Copy link

domAttributes is not super clear as a prop name. But I don't know what else to name it, I took this name from the official typescript type I took the properties from... 🤔

Could name it to pointerEvents?

@pierpo pierpo force-pushed the feature/clickable-arrows branch 2 times, most recently from 18d63d4 to f9e2ecc Compare May 7, 2024 23:40
Allows for clickable arrows, drag and droppable arrows...
@pierpo pierpo force-pushed the feature/clickable-arrows branch from f9e2ecc to f92e831 Compare May 7, 2024 23:42
@pierpo
Copy link
Owner Author

pierpo commented May 7, 2024

domAttributes is not super clear as a prop name. But I don't know what else to name it, I took this name from the official typescript type I took the properties from... 🤔

Could name it to pointerEvents?

No, because pointerEvents is a different property 😉 let's keep it as domAttributes for now!

@pierpo pierpo merged commit 544bb92 into master May 7, 2024
1 check passed
@pierpo pierpo deleted the feature/clickable-arrows branch May 7, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants