FSE API Hits Counter #178
Merged
FSE API Hits Counter #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PI in past 6 hours with 3 levels of severity
|
Hi @jsilva74 Thank you very much for your contribution! If I may, I would suggest that you update the hit counter when opening the "Load data" popup, because I can see a use case when a user has done 6 requests, then comes back to FSE Planner the next day and sees "6 requests in the last 6 hours" when opening the popup, it would be a bit confusing. |
|
Hey Piero. Sure. I'll fix it. Thanks for the insight. |
jsilva74
force-pushed
the
feat/fse-api-hits-counter
branch
from
8c19e5c
to
93c9e5a
Compare
|
@piero-la-lune, branch updated. Thanks. |
|
Looks ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case
I, as an user, wanna to know how many requests was sent to FSE API in past 6 hours to stick with FSE User Guide related to the use of API.
Proposed solution
This PR implements a counter to accumulate the total quantity of requests sent to FSE API. Also, displays this information in Update screen with 3 levels of severities.
Total of requests to FSE API up to 24 requests in past 6 hours
Total of requests to FSE API from 25 to 34 requests in past 6 hours
Total of requests to FSE API with more than 34 requests in past 6 hours