Add batch insert #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piercefreeman
force-pushed
the
feature/add-batch-insertion
branch
4 times, most recently
from
768c07f to
737a5c8
Compare
piercefreeman
force-pushed
the
feature/add-batch-insertion
branch
from
737a5c8 to
c7e394b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #7: batch object insert.
For particular backends we can make some optimizations to the batch case, versus ad-hoc inserts. Where supported we also allow users to display a progress bar to show the current status of upserts. This status update is particularly useful on remote backends like Pinecone that might have higher latency to send content over the wire.
We can likely generalize the single insertion logic to be a batch insert of size 1 in the future. For this PR we keep the implementations separate.