New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixing vanilla typehints with configured schema #8

Merged

piercefreeman merged 1 commit into main from feature/bug-fixes

Apr 25, 2023

Owner

piercefreeman commented Apr 24, 2023 •

edited

Loading

This example would previously crash since the base class was trying to migrate the configuration parameters over to the internal configuration cache:

```
    class TestMixedConfigurationObject(VectorSchemaBase):
    __collection_name__ = 'mixed_configuration_collection'

    id: int = PrimaryKeyField()
    is_valid: bool
    embedding: np.ndarray = EmbeddingField(dim=128, index=Milvus_IVF_FLAT(cluster_units=128))

```

This PR fixes this case and allows users to mix configured values with non-configured keys.


          Fix mixing vanilla typehints with configured schema

b0e42aa

piercefreeman merged commit fe168d1 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet