-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster dependency reload #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piercefreeman
force-pushed
the
feature/nested-dependency-hot-reloading
branch
2 times, most recently
from
November 22, 2024 15:11
6050300
to
4446bf8
Compare
piercefreeman
force-pushed
the
feature/nested-dependency-hot-reloading
branch
from
November 22, 2024 15:49
8e95326
to
4e85ef5
Compare
piercefreeman
force-pushed
the
feature/nested-dependency-hot-reloading
branch
from
November 22, 2024 16:28
4e85ef5
to
801c61f
Compare
piercefreeman
force-pushed
the
feature/nested-dependency-hot-reloading
branch
from
November 22, 2024 17:26
82b74ad
to
27cfdce
Compare
piercefreeman
force-pushed
the
feature/nested-dependency-hot-reloading
branch
from
November 22, 2024 17:41
20411f8
to
04da0e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our initial implementation of hot reloading worked in most cases, but there were some edge cases where it failed to update nested closures (including typehint schema changes for new controllers). It was also a bit slow on large projects since it needed to traverse modules that were in memory dynamically during every reload. Our new approach constructs a DAG of dependencies based on traversal of the project's AST. When we detect that a file has changed we just need to consult the current graph of file dependencies and traverse them in order to resolve all modifications. This also has the benefit of making our logic easier to unit test because it separates out dependency construction from the reload process.