Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With AVPlayerViewController #180

Closed
wants to merge 16 commits into from

Conversation

addbrick
Copy link
Contributor

@addbrick addbrick commented Apr 3, 2018

Adds AVPlayerViewController to be used instead of the AVPlayerLayer. This is a first pass which satisfied my use case. Not sure if it is the right direction or overkill, mainly wanted the loading functions.

Other fun things added:

  • Implements error handling delegate from another pr Add error handling to delegate #172
  • Update playbackState when the _avplayer starts playing or pauses
  • Update build target to iOS 10.0

To Finish:

  • Don't call or create playerLayer or _playerView when useNativeUI is true
  • Probably some other clean up

To Add:

  • Fullscreen detection event (to allow enable/disable of orientation change)

@piemonte
Copy link
Owner

piemonte commented Apr 4, 2018

@addbrick you're awesome, thanks for the improvements. the changes look good, will do another pass and merge in soon.

chriszielinski added a commit to chriszielinski/Player that referenced this pull request Jun 21, 2018
@piemonte
Copy link
Owner

piemonte commented Aug 3, 2018

hey, i haven't forgotten about these requests, they've blossomed, so it's more for me to review. would like to merge them in, will probably make a few changes after doing so. thanks again.

@piemonte
Copy link
Owner

piemonte commented Aug 6, 2018

merged commits to master, backed out and/or modified a couple changes

@piemonte piemonte closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants