-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With AVPlayerViewController #180
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@addbrick you're awesome, thanks for the improvements. the changes look good, will do another pass and merge in soon. |
… the player pauses or starts playing
This reverts commit 664d56d.
chriszielinski
added a commit
to chriszielinski/Player
that referenced
this pull request
Jun 21, 2018
hey, i haven't forgotten about these requests, they've blossomed, so it's more for me to review. would like to merge them in, will probably make a few changes after doing so. thanks again. |
merged commits to master, backed out and/or modified a couple changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
AVPlayerViewController
to be used instead of theAVPlayerLayer
. This is a first pass which satisfied my use case. Not sure if it is the right direction or overkill, mainly wanted the loading functions.Other fun things added:
playbackState
when the_avplayer
starts playing or pausesTo Finish:
playerLayer
or_playerView
whenuseNativeUI
istrue
To Add: