Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperability with sublimelinter #47

Closed
nejsimon opened this issue Apr 17, 2018 · 8 comments
Closed

Interoperability with sublimelinter #47

nejsimon opened this issue Apr 17, 2018 · 8 comments

Comments

@nejsimon
Copy link

It would be nice if Javascript Enhancements could be used together with SublimeLinter!

When a linter detects an error it will properly mark the code block in red but when hovering it you get something nonsensical from JavascriptEnhancements and not the expected tooltip message from SublimeLinter detailing the error. You can still see the error in the status field when placing the cursor in the code block though.

Expected Behavior

The linter error is shown when hovering the code.

Actual Behavior

A nonsensical message i shown

Sublime Text console logs

No errors in the log

Screenshots

SublimeLinter, JavaScriptEnhancements enabled
enabled
SublimeLinter enabled, JavaScriptEnhancements disabled
disabled

Steps to Reproduce the Problem

  1. Install SublimeLinter and a linter plugin for js files
  2. Install JavascriptEnhancements
  3. Write some broken code
  4. Hover the broken code when the linter detects the error

Specifications

  • Sublime Text 3 build: 3143
  • OS: Windows 7 x64
  • JavaScript Enhancements version: 0.6.12
@pichillilorenzo
Copy link
Owner

It's weird because this souldn't happen.. In this case you should see a red popup from the flow linter saying that it's an error.. Maybe there are some problems with async functions

@pichillilorenzo
Copy link
Owner

pichillilorenzo commented Apr 17, 2018

Ah no sorry, you aren't in a JavaScript project, so you need to active the flow linter using the Tools menu! See here https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Errors-and-linting

@monovertex
Copy link
Contributor

monovertex commented Apr 20, 2018

I'm encountering a similar issue, as I'm using SublimeLinter as well, with ESlint. I don't need or plan to use flow lint. In my case, JSE overrides the tooltip displayed by SublimeLinter.

With JSE enabled:
image
image

With JSE disabled:
image

It would be nice if we could set a level of priority, so that the SublimeLinter tooltip would have higher priority if needed, as I figure displaying both of them would be too complicated.

@nejsimon
Copy link
Author

That's my situation as well. We have a bunch of eslint rules including a few custom ones to enforce our code conventions so I can't switch to flow even though there might be advantages.

@pichillilorenzo
Copy link
Owner

I will check about that 👍

@pichillilorenzo
Copy link
Owner

Try the new version 0.16.14! Now it should work.

@nejsimon
Copy link
Author

It seems to be working! Thanks a lot!

@ahmadsholehin
Copy link

I seem to have this issue. Using 0.16.20, Sublime 3.2.

JSE is blocking SublimeLinter's tooltips when hovering regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants