Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-652: Skip magic link logic if we are already logged in #31

Conversation

kp-juan-docal
Copy link
Contributor

Summary

Let's avoid opening the application through the magic link logic when already logged in, as it is wrongly causing the opposite effect and logging out users.

Sanity Tests

  • While logged out. Use the magic link. Confirm it logs us in.
  • While logged in. Use the magic link. Confirm it opens the application and keeps us logged in.

Copy link
Collaborator

@kp-iva-nedeleva kp-iva-nedeleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kp-juan-docal kp-juan-docal merged commit e029058 into master Oct 4, 2023
3 checks passed
@kp-juan-docal kp-juan-docal deleted the juan.docal/pia-652-avoid-magic-link-logic-if-we-are-already-logged-in branch October 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants