-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve escaping on the web interface #2851
Conversation
Signed-off-by: DL6ER <[email protected]>
Interesting, that setting the content type works for us, but not for some users reported here: https://bugs.jquery.com/ticket/12326/ |
Signed-off-by: DL6ER <[email protected]>
ead31e2
to
a39c8a5
Compare
The small glitch I observed isn't a web issue. It will be fixed by pi-hole/FTL#1763 so I'd say this PR is indeed ready for review.
These last comments you are referring to are over 9 years old, though. I guess the issue was fixed meanwhile but just nobody remembered this issue ticket (it is "closed as invalid"). |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <[email protected]>
Conflicts have been resolved. |
What does this implement/fix?
Fixes pi-hole/FTL#1760, see pi-hole/FTL#1760 (comment) for additional context.
Before:
After:
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.