Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings level selector into sidebar #2801

Closed
wants to merge 1 commit into from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 2, 2023

What does this implement/fix?

Move settings level selector into the sidebar instead of the settings page header

Screenshot from 2023-11-02 06-15-06

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team November 2, 2023 05:16
Copy link
Contributor

github-actions bot commented Nov 3, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DL6ER DL6ER force-pushed the tweak/settings_level branch from 8308fea to f5040c5 Compare November 4, 2023 06:30
@DL6ER
Copy link
Member Author

DL6ER commented Nov 4, 2023

Rebased on latest development-v6

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Conflicts have been resolved.

@yubiuser
Copy link
Member

yubiuser commented Nov 4, 2023

What's about the idea we discussed internally: getting rid of the setting levels at all? We wanted to keep the level indicators (wrench/cog), but remove the selector and show everything always

@DL6ER
Copy link
Member Author

DL6ER commented Nov 6, 2023

Further discussion going on, I will make this a draft and remove the requested review.

@DL6ER DL6ER marked this pull request as draft November 6, 2023 14:54
@DL6ER DL6ER removed the request for review from a team November 6, 2023 14:54
@DL6ER
Copy link
Member Author

DL6ER commented Nov 29, 2023

Superseded by #2882

@DL6ER DL6ER closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants