-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mass-deletion of sessions on the settings -> API page #2765
Conversation
Signed-off-by: DL6ER <[email protected]>
Maybe it's an issue with |
I wasn't able to replicate the "all but one" issue using different browsers (Chrome, Firefox and Edge) on the same machine. You used different windows from the same browser (using incognito mode). I'm not sure if this could be related to the issue you are seeing. We probably need more tests. |
The issue was the concurrency of the deletions. This is fixed by the latest commit |
…ls finished. This also ensures our own session is NOT deleted on error so the user can still see the generated error message Signed-off-by: DL6ER <[email protected]>
5e3f2ca
to
7595ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 3 functions now with very similar names: deleteSessions()
, delSessions(ids)
and delSession(id,...)
. The first one does not do much on it's own, maybe the single line var ids = [$(this).attr("data-del-id")];
can be part of delSessions()
?
Signed-off-by: DL6ER <[email protected]>
What does this implement/fix?
See title and related Discourse topic.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.